use args rather than return params for bn254 unmarshaling #2
Conversation
Signed-off-by: garyschulte <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request enhances the implementation of EIP-196 (Elliptic curve operations on bn256) in the Besu Ethereum client, focusing on improved safety and performance.
- Introduced subgroup checks in
safeUnmarshalEIP196function for G1 points - Modified
safeUnmarshalG2EIP196to perform IsInSubGroup check instead of IsOnCurve - Added new error type
ErrPointInSubgroupCheckFailedEIP196for subgroup check failures - Updated test case
compute_invalidPointsOutsideSubgroupG2with more specific error message - Optimized function signatures to use pointers for better performance in Go implementation
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
gnark/gnark-jni/gnark-eip-196.go
Outdated
| if (!g1.IsOnCurve()) { | ||
| return nil, ErrPointOnCurveCheckFailedEIP196 | ||
| return ErrPointInSubgroupCheckFailedEIP196 | ||
| } |
There was a problem hiding this comment.
logic: IsOnCurve check replaced with IsInSubGroup, but error message is inconsistent
gnark/gnark-jni/gnark-eip-196.go
Outdated
| if (!g2.IsInSubGroup()) { | ||
| return ErrPointOnCurveCheckFailedEIP196 | ||
| } |
There was a problem hiding this comment.
logic: Subgroup check added for G2 points, but error message is inconsistent
Signed-off-by: garyschulte <[email protected]>
There was a problem hiding this comment.
PR Summary
(updates since last review)
This pull request continues to enhance the implementation of EIP-196 in the Besu Ethereum client, focusing on safer memory usage and improved function signatures.
- Modified function signatures in
gnark-eip-196.goto use arguments instead of return parameters for bn254 unmarshaling - Adjusted error handling and buffer management in Go implementation for better memory safety
- Updated Java test case in
AltBN128PairingPrecompiledContractLegacyTest.javato reflect changes in error reporting
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
for demo-ing greptile review bot